ENH: Implement Feret/Caliper distance metrics in Find Feature Sizes. #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
imikejackson
force-pushed
the
topic/feret_distance
branch
from
613bb86 to
a71f336
Compare
JDuffeyBQ
requested changes
May 2, 2024
| { | ||
| for(uint32 x = 0; x < xDim; x++) | ||
| { | ||
| index = (imageDims[1] * imageDims[0] * z) + (imageDims[0] * y) + x; // Index into featureIds array |
There was a problem hiding this comment.
Looks like this is only used inside the loop so the declaration can just become this line.
imikejackson
force-pushed
the
topic/feret_distance
branch
from
60aab33 to
cd21a32
Compare
- BlueQuartzSoftware#944 Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: Jared Duffey <[email protected]>
Co-authored-by: Jared Duffey <[email protected]>
Co-authored-by: Jared Duffey <[email protected]>
imikejackson
force-pushed
the
topic/feret_distance
branch
from
cd21a32 to
3e4fcd0
Compare
|
Closing this for now as there isn't funding to work the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Ability to determine maximum and minimum feret diameter of features. #944
Unit test implemented for the added features
Documentation updated to include the ordering of the data in the output array